Re: [PATCH] enums: remove trailing ',' after last item in enum

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jul 2, 2014, 19:58 UTC
Message-ID: <20140702195805.GD5816@google.com>
In-Reply-To: <1404325445-17914-1-git-send-email-sahlberg@google.com>

Ronnie Sahlberg wrote:

Show 6 quoted lines

> Signed-off-by: Ronnie Sahlberg <sahlberg@google.com>
> ---
>  builtin/clean.c | 2 +-
>  builtin/tag.c   | 2 +-
>  pretty.c        | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)

Is there some gcc option or other tool that can automatically detect this kind of problem so the regress/fix cycle doesn't have to repeat too many times?

Looks like v1.7.2-rc0~32^2~16 (2010-03-14) and v1.7.4.2~34 (2011-03-16) tried to fix this in the past.

Using the test from v1.7.4.2~34 also finds enums with trailing comma in

 grep.h
 log-tree.c

Thanks, Jonathan