Re: recent cygwin breakage

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 23, 2014, 18:13 UTC
Message-ID: <xmqqr3wtyed6.fsf@gitster.dls.corp.google.com>
In-Reply-To: <5470B9F9.2060008@ramsay1.demon.co.uk>

Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:

Show 15 quoted lines

> Just a quick heads-up on a recent cygwin breakage.
> 
> I updated my (64-bit) cygwin installation yesterday and (along
> with many other packages) I noticed a new version of gcc (and
> presumably libc) was installed (gcc v4.8.3-5 x86-64).
> ...
> However, I haven't run any tests yet. Also, I would need to check
> this out on 32-bit cygwin (I haven't booted that laptop into Win XP
> for quite some time!).
>
> Hmm, I don't really know if this is an unintended side-effect of a
> recent change to cygwin (or a bug), but I couldn't see any mention
> of this on the cygwin mailing list. (I don't intend to report this
> to that mailing list; I don't want to subscribe to (yet another)
> busy list). :(

Thanks.

I wonder if it is safe to unconditionally drop XOPEN_SOURCE; would it cause problems for older Cygwin to those who have not updated to the recent one yet? The proposed change looks trivially correct otherwise.