Re: [PATCH 03/14] copy_fd: pass error message back through a strbuf
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 3, 2014, 20:02 UTC
- Message-ID
- <xmqqr3wgh57t.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <20141203051344.GM6527@google.com>
Jonathan Nieder <jrnieder@gmail.com> writes:
Show 15 quoted lines
> This way, callers can put the message in context or even avoid > printing the message altogether. > > Currently hold_lock_file_for_append tries to save errno in order to > produce a meaningful message about the failure and tries to print a > second message using errno. Unfortunately the errno it uses is not > meaningful because copy_fd makes no effort to set a meaningful errno > value. This change is preparation for simplifying the > hold_lock_file_for_append behavior. > > No user-visible change intended yet. > > Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> > --- > The title feature.
By the way, this seems to address the same thing as sb/copy-fd-errno topic that has been cooking in 'pu'? Should we drop that other topic and use this one instead?