Re: [PATCH] copy.c: make copy_fd preserve meaningful errno

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 18, 2014, 17:08 UTC
Message-ID: <xmqqk32swi5r.fsf@gitster.dls.corp.google.com>
In-Reply-To: <xmqqtx1wwjtv.fsf@gitster.dls.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 5 quoted lines

> In short I am not a very big fan of passing around strbuf *err to
> low level helper API functions myself.
>
> But the approach does not make things much worse than it currently
> is, other than code churns to pass an extra pointer around.

Sorry I left the conclusion out of the message.

As it does not make things much worse, and does give slightly better flexibility on error message emission to the callers, let's go with the "strbuf *err" arpporach for now.

Until we hit a wall we cannot climb over, at which time we may need to redo it, but let's first see how it goes.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.