Re: [PATCH v5 3/3] t0302: test credential-store support for XDG_CONFIG_HOME
Junio C Hamano <gitster@pobox.com> writes:
Show 14 quoted lines
> Eric Sunshine <sunshine@sunshineco.com> writes:
>
>> On Tue, Mar 24, 2015 at 5:52 AM, Matthieu Moy
>> ...
>>> Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr>
>>
>> With the POSIXPERM issue[1] addressed (if necessary), patch 3/3 is also:
>>
>> Reviewed-by: Eric Sunshine <sunshine@sunshineco.com>
>
> THanks for a review. Paul, the 3-patch series is already in 'next',
> so please fix these up with a follow-up patch.
>
> Thanks.
I've already queued the following and merged it to 'next'.
-- >8 --
From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 25 Mar 2015 13:23:21 -0700
Subject: [PATCH] t0302: "unreadable" test needs POSIXPERM
Noticed and fixed by Eric Sunshine, confirmed by Johannes Sixt.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
t/t0302-credential-store.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t0302-credential-store.sh b/t/t0302-credential-store.sh
index 4e1f8ec..0979df9 100755
--- a/t/t0302-credential-store.sh
+++ b/t/t0302-credential-store.sh
@@ -75,7 +75,7 @@ test_expect_success 'get: use xdg file if home file has no matches' '
EOF
'
-test_expect_success 'get: use xdg file if home file is unreadable' '
+test_expect_success POSIXPERM 'get: use xdg file if home file is unreadable' '
echo "https://home-user:home-pass@example.com" >"$HOME/.git-credentials" &&
chmod -r "$HOME/.git-credentials" &&
mkdir -p "$HOME/.config/git" &&
--
2.3.4-462-gc8eeafd
Junio C Hamano <gitster@pobox.com>