git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5 3/3] t0302: test credential-store support for XDG_CONFIG_HOME

From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date
Mar 24, 2015, 09:52 UTC
Message-ID
<vpqbnjivi2n.fsf@anie.imag.fr>
In-Reply-To
<1427174429-5876-3-git-send-email-pyokagan@gmail.com>
Paul Tan <pyokagan@gmail.com> writes:
Show 10 quoted lines
> Matthieu and Eric: I know I said I will try to re-order the patches to
> put the tests before the implementation, but after thinking and trying
> to rewrite the commit messages I realised it seems really weird to me.
> In this patch series, the implementation is split across the first two
> patches. The first patch should use the old tests, and ideally, the new
> tests should be squashed with the second patch because it seems more
> logical to me to implement the tests at the same time as the new
> feature. However, since the tests patch is very long, to make it easier
> to review it is split into a separate patch which is applied after the
> implementation patches.

No problem, your version is very good. I was pointing out alternatives, but not requesting a change, and your reasoning makes perfect sense.

I had reviewed v4 in details, and checked the diff between v4 and v5. The whole series is now

Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr>
Thanks,
-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Previous: Paul TanNext: Eric Sunshine
Message 4 of 11 in “git-credential-store: support multiple credential files”
  1. 1/3 git-credential-store: support multiple credential filesPaul Tan, Mar 24, 2015
  2. 2/3 git-credential-store: support XDG_CONFIG_HOMEPaul Tan, Mar 24, 2015
  3. 3/3 t0302: test credential-store support for XDG_CONFIG_HOMEPaul Tan, Mar 24, 2015
  4. Matthieu MoyMar 24, 2015
  5. Eric SunshineMar 25, 2015
  6. Junio C HamanoMar 25, 2015
  7. Junio C HamanoMar 25, 2015
  8. Paul TanMar 26, 2015
  9. Matthieu MoyMar 26, 2015
  10. Eric SunshineMar 25, 2015
  11. Johannes SixtMar 25, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.