Re: [PATCH v6 0/4] Add --base option to git-format-patch to record base tree info
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 27, 2016, 15:04 UTC
- Message-ID
- <xmqqr3dray9e.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20160427073350.GA30342@yexl-desktop>
Ye Xiaolong <xiaolong.ye@intel.com> writes:
Show 7 quoted lines
> On Tue, Apr 26, 2016 at 11:58:39AM -0700, Junio C Hamano wrote: > >>Let's hear from folks at Intel ;-) Both of the above sounds like >>sensible enhancements to me. > > Shall I squash these enhancements in this series, or I need to make > another patch for them?
The update being discussed is not a "oops, the series without this update is embarrassingly flawed" fix, but rather "the series is good enough to be used as-is, but here is to potentially make it even better", I'd prefer to have it as a separate, follow-up patch that applies on top of what has been queued. That way, if this turns out to be not so good idea, removing it alone while preserving what is already there will be easier, and also others who will be studying the code to further enhance the heuristics of base selection in the future will benefit.