git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v6 0/4] Add --base option to git-format-patch to record base tree info

From
Stefan Beller <sbeller@google.com>
Date
Apr 27, 2016, 15:45 UTC
Message-ID
<CAGZ79kbvdTTLReVrrO8X0jTJn5kDn1n1cAS1Fo+-jWdGK5G1LQ@mail.gmail.com>
In-Reply-To
<xmqqr3dray9e.fsf@gitster.mtv.corp.google.com>
On Wed, Apr 27, 2016 at 8:04 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 19 quoted lines
> Ye Xiaolong <xiaolong.ye@intel.com> writes:
>
>> On Tue, Apr 26, 2016 at 11:58:39AM -0700, Junio C Hamano wrote:
>>
>>>Let's hear from folks at Intel ;-) Both of the above sounds like
>>>sensible enhancements to me.
>>
>> Shall I squash these enhancements in this series, or I need to make
>> another patch for them?
>
> The update being discussed is not a "oops, the series without this
> update is embarrassingly flawed" fix, but rather "the series is good
> enough to be used as-is, but here is to potentially make it even
> better", I'd prefer to have it as a separate, follow-up patch that
> applies on top of what has been queued.  That way, if this turns out
> to be not so good idea, removing it alone while preserving what is
> already there will be easier, and also others who will be studying
> the code to further enhance the heuristics of base selection in the
> future will benefit.

I agree. I was just suggesting going the extra mile to make it easier for the user. :)

Previous: Junio C HamanoNext: Stefan Beller
Message 15 of 16 in “Add --base option to git-format-patch to record base tree info”
  1. 0/4 Add --base option to git-format-patch to record base tree infoXiaolong Ye, Apr 26, 2016
  2. 1/4 patch-ids: make commit_patch_id() a public helper functionXiaolong Ye, Apr 26, 2016
  3. 2/4 format-patch: add '--base' option to record base tree infoXiaolong Ye, Apr 26, 2016
  4. 3/4 format-patch: introduce --base=auto optionXiaolong Ye, Apr 26, 2016
  5. 4/4 format-patch: introduce format.useAutoBase configurationXiaolong Ye, Apr 26, 2016
  6. Stefan BellerApr 26, 2016
  7. Stefan BellerApr 26, 2016
  8. Junio C HamanoApr 26, 2016
  9. Stefan BellerApr 26, 2016
  10. Junio C HamanoApr 26, 2016
  11. Stefan BellerApr 26, 2016
  12. Junio C HamanoApr 26, 2016
  13. Ye XiaolongApr 27, 2016
  14. Junio C HamanoApr 27, 2016
  15. Stefan BellerApr 27, 2016
  16. Stefan BellerApr 26, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.