Re: [PATCH v3 3/5] sha1_name: Unroll len loop in find_unique_abbrev_r
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 5, 2017, 09:50 UTC
- Message-ID
- <xmqqr2uh7wjs.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20171005091334.7oyjaco432l5p6ft@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
> So I think on the generating side we are better off creating a slightly > longer abbreviation that is unambiguous no matter what context it is > used in. I.e., I'd argue that it's actually more _correct_ to ignore > the disambiguation code entirely on the generating side.
OK. Thanks for sanity checking.