Re: [PATCH v5 2/2] launch_editor(): indicate that Git waits for user input

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 7, 2017, 15:43 UTC
Message-ID: <xmqqr2s6ee7e.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20171207151641.75065-3-lars.schneider@autodesk.com>

lars.schneider@autodesk.com writes:

Show 11 quoted lines

> +		if (print_waiting_for_editor) {
> +			fprintf(stderr,
> +				_("hint: Waiting for your editor to close the file... "));
> +			if (is_terminal_dumb())
> +				/*
> +				 * A dumb terminal cannot erase the line later on. Add a
> +				 * newline to separate the hint from subsequent output.
> +				 */
> +				fprintf(stderr, "\n");
> +			fflush(stderr);
> +		}

Was the trailing whitespace at the end of the hint message intended?

If we expect the editor to spit out additional garbage on the line, it would probably help to have that SP, but if that is why we have it there, it probably should be done only when !is_terminal_dumb().

If the trailing SP is merely there by accident, then removal without changing anything else is also OK.

I cannot tell which is the case, hence this comment.

Thanks.