Re: [PATCH v5 2/2] launch_editor(): indicate that Git waits for user input

From: Lars Schneider <larsxschneider@gmail.com>
Date: Dec 7, 2017, 16:16 UTC
Message-ID: <D17F94FA-702E-4E37-BDA5-94F0FFD5BD01@gmail.com>
In-Reply-To: <FCBDBD58-0593-4FFC-B574-61D67CAF13C6@gmail.com>

Show 21 quoted lines

> On 07 Dec 2017, at 16:48, Lars Schneider <larsxschneider@gmail.com> wrote:
> 
> 
>> On 07 Dec 2017, at 16:43, Junio C Hamano <gitster@pobox.com> wrote:
>> 
>> lars.schneider@autodesk.com writes:
>> ...
> 
> How about this?
> 
> 			fprintf(stderr,
> 				_("hint: Waiting for your editor to close the file..."));
> 			if (is_terminal_dumb())
> 				/*
> 				 * A dumb terminal cannot erase the line later on. Add a
> 				 * newline to separate the hint from subsequent output.
> 				 */
> 				fprintf(stderr, "\n")
> 			else
> 				fprintf(stderr, " ")
>

I forgot the ";" ... switching between programming languages ;-)

			if (is_terminal_dumb())
				/*
				 * A dumb terminal cannot erase the line later on. Add a
				 * newline to separate the hint from subsequent output.
				 */
				fprintf(stderr, "\n");
			else
				fprintf(stderr, " ");

> Can you squash that if you like it?
> 
> Thanks,
> Lars