Re: [PATCH v2 03/24] multi-pack-index: add builtin
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 25, 2018, 19:15 UTC
- Message-ID
- <xmqqr2kuoexh.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <20180625143434.89044-4-dstolee@microsoft.com>
Derrick Stolee <stolee@gmail.com> writes:
Show 29 quoted lines
> This new 'git multi-pack-index' builtin will be the plumbing access > for writing, reading, and checking multi-pack-index files. The > initial implementation is a no-op. > > Signed-off-by: Derrick Stolee <dstolee@microsoft.com> > --- > .gitignore | 3 +- > Documentation/git-multi-pack-index.txt | 36 ++++++++++++++++++++++++ > Makefile | 1 + > builtin.h | 1 + > builtin/multi-pack-index.c | 38 ++++++++++++++++++++++++++ > command-list.txt | 1 + > git.c | 1 + > 7 files changed, 80 insertions(+), 1 deletion(-) > create mode 100644 Documentation/git-multi-pack-index.txt > create mode 100644 builtin/multi-pack-index.c > > diff --git a/.gitignore b/.gitignore > index 388cc4beee..25633bc515 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -99,8 +99,9 @@ > /git-mergetool--lib > /git-mktag > /git-mktree > -/git-name-rev > +/git-multi-pack-index > /git-mv > +/git-name-rev
Nice attention to the detail (even though the patch as an incremental change gets distracting, the result is better and future changes to the file will read cleaner).
Show 30 quoted lines
> diff --git a/Documentation/git-multi-pack-index.txt b/Documentation/git-multi-pack-index.txt > new file mode 100644 > index 0000000000..9877f9c441 > --- /dev/null > +++ b/Documentation/git-multi-pack-index.txt > @@ -0,0 +1,36 @@ > +git-multi-pack-index(1) > +====================== > + > +NAME > +---- > +git-multi-pack-index - Write and verify multi-pack-indexes > + > + > +SYNOPSIS > +-------- > +[verse] > +'git multi-pack-index' [--object-dir <dir>] > + > +DESCRIPTION > +----------- > +Write or verify a multi-pack-index (MIDX) file. > + > +OPTIONS > +------- > + > +--object-dir <dir>:: > + Use given directory for the location of Git objects. We check > + <dir>/packs/multi-pack-index for the current MIDX file, and > + <dir>/packs for the pack-files to index.
Do we want to `quote` these constant strings?
Show 12 quoted lines
> diff --git a/builtin/multi-pack-index.c b/builtin/multi-pack-index.c
> new file mode 100644
> index 0000000000..f101873525
> --- /dev/null
> +++ b/builtin/multi-pack-index.c
> @@ -0,0 +1,38 @@
> +#include "builtin.h"
> +#include "cache.h"
> +#include "config.h"
> +#include "parse-options.h"
> +
> +static char const * const builtin_multi_pack_index_usage[] ={ERROR: spaces required around that '=' (ctx:WxV)
#112: FILE: builtin/multi-pack-index.c:6:
+static char const * const builtin_multi_pack_index_usage[] ={
^