Re: [PATCH v4 03/23] multi-pack-index: add builtin

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Jul 20, 2018, 22:15 UTC
Message-ID: <20180720221522.GD18502@genre.crustytoothpaste.net>
In-Reply-To: <xmqqva99bwdw.fsf@gitster-ct.c.googlers.com>

On Fri, Jul 20, 2018 at 11:22:03AM -0700, Junio C Hamano wrote:

Show 14 quoted lines

> Derrick Stolee <stolee@gmail.com> writes:
> 
> > diff --git a/Documentation/git-multi-pack-index.txt b/Documentation/git-multi-pack-index.txt
> > new file mode 100644
> > index 0000000000..ec9982cbfc
> > --- /dev/null
> > +++ b/Documentation/git-multi-pack-index.txt
> > @@ -0,0 +1,36 @@
> > +git-multi-pack-index(1)
> > +======================
> 
> Isn't this underline too short by one column?  My copy of AsciiDoc
> seems to be OK with it, but do other versions and reimplementations
> groke this fine?

I believe AsciiDoc allows a two-character grace (either longer or shorter) and Asciidoctor allows one. So this should work both places (although I haven't tested).

It might be nice to fix if a re-roll is needed, but it should be functional as-is.

-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204