Re: js/mingw-wants-vista-or-above, was Re: What's cooking in git.git (Oct 2018, #01; Wed, 10)

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 10, 2018, 13:13 UTC
Message-ID: <xmqqr2gykkqq.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <nycvar.QRO.7.76.6.1810101502220.2034@tvgsbejvaqbjf.bet>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 18 quoted lines

> Hi Junio,
>
> On Wed, 10 Oct 2018, Junio C Hamano wrote:
>
>> * js/mingw-wants-vista-or-above (2018-10-04) 3 commits
>>  - mingw: bump the minimum Windows version to Vista
>>  - mingw: set _WIN32_WINNT explicitly for Git for Windows
>>  - compat/poll: prepare for targeting Windows Vista
>> 
>>  The minimum version of Windows supported by Windows port fo Git is
>>  now set to Vista.
>> 
>>  Will merge to 'next'.
>
> Could I ask you to fast-track this to `master`? The code in `master`
> unfortunately no longer compiles in a current Git for Windows SDK, meaning
> that all of our Continuous Testing fails as long as these patches are not
> merged.

Absolutely. There is no point keeping it in 'pu', as nobody would touch it in my tree until it hits 'next' and probably 'master' and the change would get wider exposure to folks to whom it matters in your tree anyway.

Thanks for pinging.