Re: What's cooking in git.git (Oct 2018, #01; Wed, 10)

From: Stefan Beller <sbeller@google.com>
Date: Oct 11, 2018, 23:06 UTC
Message-ID: <CAGZ79ka1pxPt+xT3vBa5xARG5P+Hd19sjOLO_y_zofVStsDWNQ@mail.gmail.com>
In-Reply-To: <xmqqa7nkf6o4.fsf@gitster-ct.c.googlers.com>

On Thu, Oct 11, 2018 at 3:41 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 11 quoted lines

>  * After fixing ignore-any to one of the supported option
>    (e.g. "ignore-all-spaces"), the color-moved feature still did not
>    trigger.  I think the presence of --color-moved-ws by itself is a
>    hint that the user wants --color-moved to be used.  If it turns
>    out that there are some valid use cases where --color-moved-ws
>    may have to be set but the color-moved feature should not be
>    enabled, then
>
>         diff --color-moved-ws=ignore-all-space --no-color-moved
>
>    can be used to countermand this, of course.

I had the same idea for --color-moved to imply --color, but there we had some issues with configured settings, as we do not want diff.colorMoved to imply colored patches, but only when given on the command line.

I think we should add these tweaks, such that color-moved-ws implies color-moved (both config and CLI options) and --color-moved implies --color (command line only)