Re: [PATCH 2/3] send-email: only consider lines containing @ or <> for automatic Cc'ing

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 11, 2018, 08:22 UTC
Message-ID: <xmqqr2gwgaef.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <f5c401a6-f329-1076-ab4b-2f52915047bf@rasmusvillemoes.dk>

Rasmus Villemoes <rv@rasmusvillemoes.dk> writes:

> So, it seems you're ok with this tightening, but some comment on the
> non-interactive use case should be made in the commit log? Or am I
> misunderstanding?

I do not think we need any immediate action on this step. I was just wondering if we want two classes of "I am not running you interactively, so assume I said 'yes' when you need to ask me any confirmation on X and Y" and "I am not running you interactively, so assume I said 'no' for safety when you need to ask me any confirmation on Z" supported in the future. Lines with both @ and <> fall into the first class, while lines with only <> fall into the second camp, I would guess.