Re: [PATCH 3/3] send-email: also pick up cc addresses from -by trailers

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Oct 10, 2018, 12:51 UTC
Message-ID: <8736teezha.fsf@evledraar.gmail.com>
In-Reply-To: <20181010111351.5045-4-rv@rasmusvillemoes.dk>

On Wed, Oct 10 2018, Rasmus Villemoes wrote:

Show 5 quoted lines

> -				next if $suppress_cc{'sob'} and $what =~ /Signed-off-by/i;
> +				next if $suppress_cc{'sob'} and $what =~ /^Signed-off-by$/i;
> +				next if $suppress_cc{'misc-by'}
> +					and $what =~ /-by$/i and $what !~ /^Signed-off-by$/i;
>  				next if $suppress_cc{'bodycc'} and $what =~ /Cc/i;

Looks good, FWIW I was curious if this could be:

    next if $suppress_cc{'misc-by'} and $what =~ /(?<!^Signed-off)-by$/;

But found that as soon as you add a /i Perl will barf on it, and in any case makes sense to be less clever about regex features.