git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] multi-pack-index: avoid dead store for struct progress

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 19, 2018, 02:26 UTC
Message-ID
<xmqqr2gm3c4v.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20181018185920.22975-1-carenas@gmail.com>
Carlo Marcelo Arenas Belón  <carenas@gmail.com> writes:
Show 20 quoted lines
> it is initialized unconditionally by a call to start_progress
> below.
>
> Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
> ---
>  midx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/midx.c b/midx.c
> index ea2f3ffe2e..4fac0cd08a 100644
> --- a/midx.c
> +++ b/midx.c
> @@ -941,7 +941,7 @@ static void midx_report(const char *fmt, ...)
>  int verify_midx_file(const char *object_dir)
>  {
>  	uint32_t i;
> -	struct progress *progress = NULL;
> +	struct progress *progress;
>  	struct multi_pack_index *m = load_multi_pack_index(object_dir, 1);
>  	verify_midx_error = 0;

Both changes make sense. It's kind of surprising that this still matters, though; I would have expected a compiler would notice.

Previous: Carlo Arenas
Message 4 of 4 in “multi-pack-index: avoid dead store for struct progress”
  1. multi-pack-index: avoid dead store for struct progressCarlo Marcelo Arenas Belón, Oct 18, 2018
  2. Derrick StoleeOct 18, 2018
  3. Carlo ArenasOct 18, 2018
  4. Junio C HamanoOct 19, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.