Re: [PATCH] multi-pack-index: avoid dead store for struct progress
- From
Derrick Stolee <stolee@gmail.com>
- Date
- Oct 18, 2018, 19:36 UTC
- Message-ID
- <16e462a7-cdd6-9d5d-d740-d5241485787b@gmail.com>
- In-Reply-To
- <20181018185920.22975-1-carenas@gmail.com>
On 10/18/2018 2:59 PM, Carlo Marcelo Arenas Belón wrote:
Show 21 quoted lines
> it is initialized unconditionally by a call to start_progress
> below.
>
> Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
> ---
> midx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/midx.c b/midx.c
> index ea2f3ffe2e..4fac0cd08a 100644
> --- a/midx.c
> +++ b/midx.c
> @@ -941,7 +941,7 @@ static void midx_report(const char *fmt, ...)
> int verify_midx_file(const char *object_dir)
> {
> uint32_t i;
> - struct progress *progress = NULL;
> + struct progress *progress;
> struct multi_pack_index *m = load_multi_pack_index(object_dir, 1);
> verify_midx_error = 0;
> This makes sense as a cleanup. Is there a tool that reports a wasted initialization that you used to find this?
-Stolee