Re: [PATCH] clone: respect user supplied origin name when setting up partial clone

From: Junio C Hamano <gitster@pobox.com>
Date: May 29, 2019, 19:59 UTC
Message-ID: <xmqqr28hxc9t.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190524001525.12952-1-delphij@google.com>

Xin Li <delphij@google.com> writes:

Show 5 quoted lines

> Signed-off-by: Xin Li <delphij@google.com>
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
> ---
>  builtin/clone.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks. Can you add a test to demonstrate existing breakage without this single-line code change in the same patch?

Show 14 quoted lines

>
> diff --git a/builtin/clone.c b/builtin/clone.c
> index 50bde99618..822208a346 100644
> --- a/builtin/clone.c
> +++ b/builtin/clone.c
> @@ -1215,7 +1215,7 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
>  			remote_head_points_at, &branch_top);
>  
>  	if (filter_options.choice)
> -		partial_clone_register("origin", &filter_options);
> +		partial_clone_register(option_origin, &filter_options);
>  
>  	if (is_local)
>  		clone_local(path, git_dir);