Re: [PATCH] Use user supplied origin name for extension.partialcone instead of hardcoded value.
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- May 24, 2019, 00:01 UTC
- Message-ID
- <20190524000150.GD70860@google.com>
- In-Reply-To
- <20190523235543.4342-1-delphij@google.com>
Xin Li wrote:
> Subject: Use user supplied origin name for extension.partialcone instead of hardcoded value.
Good catch!
Nits:
- s/partialcone/partialclone/ (missing "l")
- subject lines in git.git tend to be of the form "subsystem: lowercase summary" with no trailing period. So maybe something like:
clone: respect user supplied origin name when setting up partial clone
> Signed-off-by: Xin Li <delphij@google.com> > --- > builtin/clone.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
The change looks obviously good. With or without a commit message change like suggested above,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Thanks.