git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Use user supplied origin name for extension.partialcone instead of hardcoded value.

From
Jonathan Nieder <jrnieder@gmail.com>
Date
May 24, 2019, 00:01 UTC
Message-ID
<20190524000150.GD70860@google.com>
In-Reply-To
<20190523235543.4342-1-delphij@google.com>
Xin Li wrote:
> Subject: Use user supplied origin name for extension.partialcone instead of hardcoded value.
Good catch!
Nits:
- s/partialcone/partialclone/ (missing "l")
- subject lines in git.git tend to be of the form
  "subsystem: lowercase summary" with no trailing period.  So maybe
  something like:
	clone: respect user supplied origin name when setting up partial clone
> Signed-off-by: Xin Li <delphij@google.com>
> ---
>  builtin/clone.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

The change looks obviously good. With or without a commit message change like suggested above,

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Thanks.
Previous: Xin LiNext: Xin Li
Message 2 of 7 in “Use user supplied origin name for extension.partialcone instead of hardcoded value.”
  1. Use user supplied origin name for extension.partialcone instead of hardcoded value.Xin Li, May 23, 2019
  2. Jonathan NiederMay 24, 2019
  3. clone: respect user supplied origin name when setting up partial cloneXin Li, May 24, 2019
  4. Junio C HamanoMay 29, 2019
  5. clone: respect user supplied origin name when setting up partial cloneXin Li, May 29, 2019
  6. clone: respect user supplied origin name when setting up partial cloneXin Li, May 29, 2019
  7. clone: respect user supplied origin name when setting up partial cloneXin Li, May 29, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.