Re: [Outreachy][PATCH] abspath: reconcile `dir_exists()` and `is_directory()`

From

Junio C Hamano <gitster@pobox.com>

Date

Oct 25, 2019, 02:40 UTC

Message-ID

<xmqqr231eedi.fsf@gitster-ct.c.googlers.com>

In-Reply-To

<20191024205100.GB30715@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> Yeah, I think one path forward could be:
>
>   - add path_exists(); this will work the same as file_exists(), but is
>     a better name. Keep file_exists() for now, but put a comment that
>     new calls should use path_exists().
>
>   - use path_exists() in builtin/clone.c, ditching its custom
>     dir_exists()

Both are of immediate value ;-)

>   - (optional) start converting file_exists() calls to path_exists(),
>     after confirming what each call wants (just files, or any path)