git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [GSoC Patch v3 1/2] lib-log-graph: consolidate test_cmp_graph logic

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 24, 2020, 21:17 UTC
Message-ID
<xmqqr1yjofc7.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20200224133814.100150-1-abhishekkumar8222@gmail.com>
Abhishek Kumar <abhishekkumar8222@gmail.com> writes:
Show 10 quoted lines
> Changes in v3:
> - Elaborate on first commit message.
> - Fix SP violations in lib-log-graph.
>
> Changes in v2:
> - Arrange patches by functions changed instead of files changed.
> - Rename library functions by prepending 'lib_'.
> - Drop outdated sanitization calls to sed.
> - Create specialized helpers to reduce code noise.
> - Fix style violations.

This round looks quite polished. I'll queue after massaging the log message of the first step.

Thanks.
Previous: Abhishek Kumar
Message 18 of 18 in “lib-log-graph.sh: consolidate test_cmp_graph logic”
  1. 1/5 lib-log-graph.sh: consolidate test_cmp_graph logicAbhishek Kumar, Feb 16, 2020
  2. 2/5 t3430: use lib-log-graph functionsAbhishek Kumar, Feb 16, 2020
  3. Junio C HamanoFeb 19, 2020
  4. 3/5 t4215: use lib-log-graph functionsAbhishek Kumar, Feb 16, 2020
  5. Junio C HamanoFeb 19, 2020
  6. 5/5 t4202: use lib-log-graph functionsAbhishek Kumar, Feb 16, 2020
  7. Junio C HamanoFeb 19, 2020
  8. 4/5 t4214: use lib-log-graph functionsAbhishek Kumar, Feb 16, 2020
  9. Junio C HamanoFeb 19, 2020
  10. Junio C HamanoFeb 17, 2020
  11. Junio C HamanoFeb 19, 2020
  12. 0/2 Consolidate test_cmp_graph logicAbhishek Kumar, Feb 20, 2020
  13. 2/2 lib-log-graph: consolidate colored graph cmp logicAbhishek Kumar, Feb 20, 2020
  14. 1/2 lib-log-graph: consolidate test_cmp_graph logicAbhishek Kumar, Feb 20, 2020
  15. Junio C HamanoFeb 20, 2020
  16. 1/2 lib-log-graph: consolidate test_cmp_graph logicAbhishek Kumar, Feb 24, 2020
  17. 2/2 lib-log-graph: consolidate colored graph cmp logicAbhishek Kumar, Feb 24, 2020
  18. Junio C HamanoFeb 24, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.