Re: [GSoC Patch v3 1/2] lib-log-graph: consolidate test_cmp_graph logic
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 24, 2020, 21:17 UTC
- Message-ID
- <xmqqr1yjofc7.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <20200224133814.100150-1-abhishekkumar8222@gmail.com>
Abhishek Kumar <abhishekkumar8222@gmail.com> writes:
Show 10 quoted lines
> Changes in v3: > - Elaborate on first commit message. > - Fix SP violations in lib-log-graph. > > Changes in v2: > - Arrange patches by functions changed instead of files changed. > - Rename library functions by prepending 'lib_'. > - Drop outdated sanitization calls to sed. > - Create specialized helpers to reduce code noise. > - Fix style violations.
This round looks quite polished. I'll queue after massaging the log message of the first step.
Thanks.