git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [GSoC Patch 5/5] t4202: use lib-log-graph functions

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 19, 2020, 17:31 UTC
Message-ID
<xmqqlfoyfpr9.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20200216134750.18947-5-abhishekkumar8222@gmail.com>
Abhishek Kumar <abhishekkumar8222@gmail.com> writes:
Show 36 quoted lines
> Helped-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> Signed-off-by: Abhishek Kumar <abhishekkumar8222@gmail.com>
> ---
>  t/t4202-log.sh | 49 ++++++++++---------------------------------------
>  1 file changed, 10 insertions(+), 39 deletions(-)
>
> diff --git a/t/t4202-log.sh b/t/t4202-log.sh
> index 192347a3e1..403d88bb33 100755
> --- a/t/t4202-log.sh
> +++ b/t/t4202-log.sh
> @@ -5,6 +5,7 @@ test_description='git log'
>  . ./test-lib.sh
>  . "$TEST_DIRECTORY/lib-gpg.sh"
>  . "$TEST_DIRECTORY/lib-terminal.sh"
> +. "$TEST_DIRECTORY/lib-log-graph.sh"
>  
>  test_expect_success setup '
>  
> @@ -452,8 +453,7 @@ cat > expect <<EOF
>  EOF
>  
>  test_expect_success 'simple log --graph' '
> -	git log --graph --pretty=tformat:%s >actual &&
> -	test_cmp expect actual
> +	test_cmp_graph_file --pretty=tformat:%s
>  '
>  
>  cat > expect <<EOF
> @@ -467,8 +467,7 @@ cat > expect <<EOF
>  EOF
>  
>  test_expect_success 'simple log --graph --line-prefix="123 "' '
> -	git log --graph --line-prefix="123 " --pretty=tformat:%s >actual &&
> -	test_cmp expect actual
> +	test_cmp_graph_file --line-prefix="123 " --pretty=tformat:%s
>  '

Like [4/5], and unlike [2/5] and [3/5], this step also does seem like an improvement.

Previous: Abhishek KumarNext: Abhishek Kumar
Message 7 of 18 in “lib-log-graph.sh: consolidate test_cmp_graph logic”
  1. 1/5 lib-log-graph.sh: consolidate test_cmp_graph logicAbhishek Kumar, Feb 16, 2020
  2. 2/5 t3430: use lib-log-graph functionsAbhishek Kumar, Feb 16, 2020
  3. Junio C HamanoFeb 19, 2020
  4. 3/5 t4215: use lib-log-graph functionsAbhishek Kumar, Feb 16, 2020
  5. Junio C HamanoFeb 19, 2020
  6. 5/5 t4202: use lib-log-graph functionsAbhishek Kumar, Feb 16, 2020
  7. Junio C HamanoFeb 19, 2020
  8. 4/5 t4214: use lib-log-graph functionsAbhishek Kumar, Feb 16, 2020
  9. Junio C HamanoFeb 19, 2020
  10. Junio C HamanoFeb 17, 2020
  11. Junio C HamanoFeb 19, 2020
  12. 0/2 Consolidate test_cmp_graph logicAbhishek Kumar, Feb 20, 2020
  13. 2/2 lib-log-graph: consolidate colored graph cmp logicAbhishek Kumar, Feb 20, 2020
  14. 1/2 lib-log-graph: consolidate test_cmp_graph logicAbhishek Kumar, Feb 20, 2020
  15. Junio C HamanoFeb 20, 2020
  16. 1/2 lib-log-graph: consolidate test_cmp_graph logicAbhishek Kumar, Feb 24, 2020
  17. 2/2 lib-log-graph: consolidate colored graph cmp logicAbhishek Kumar, Feb 24, 2020
  18. Junio C HamanoFeb 24, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.