Re: [PATCH v3] userdiff: support Bash

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 22, 2020, 17:30 UTC
Message-ID: <xmqqr1pqmamq.fsf@gitster.c.googlers.com>
In-Reply-To: <0d9f9ad1-2ba7-567e-97a1-a96f0b7cd4be@kdbg.org>

Johannes Sixt <j6t@kdbg.org> writes:

Show 14 quoted lines

> Am 22.10.20 um 01:45 schrieb Victor Engmark:
>> diff --git a/Documentation/gitattributes.txt b/Documentation/gitattributes.txt
>> index 2d0a03715b..5e8a973449 100644
>> --- a/Documentation/gitattributes.txt
>> +++ b/Documentation/gitattributes.txt
>> @@ -802,6 +802,9 @@ patterns are available:
>>  
>>  - `ada` suitable for source code in the Ada language.
>>  
>> +- `bash` suitable for source code in the Bourne-Again SHell language.
>> +  Covers a superset of POSIX function definitions.
>
> OK. POSIX *shell* function definitions would have been even better, but
> I think I can live with this version.

I can't, so I'll locally amend ...

> This is very well done. Thank you!
>
> Acked-by: Johannes Sixt <j6t@kdbg.org>

... and with this in the trailer block.

Thanks, both.  Queued.