Re: [PATCH v2] userdiff: support Bash

From: Victor Engmark <victor@engmark.name>
Date: Oct 21, 2020, 22:48 UTC
Message-ID: <f56cff1c617de3fa0ce6ebff106dab629565e1fa.camel@engmark.name>
In-Reply-To: <a07042af-d16c-1975-c0d1-f22f4fec5827@kdbg.org>

On Wed, 2020-10-21 at 09:07 +0200, Johannes Sixt wrote:

Show 12 quoted lines

> Am 21.10.20 um 05:00 schrieb Victor Engmark:
> > Uses the default `IFS` characters to define words.
> 
> We could do better than this, I think. At a minimum, the equal sign,
> single quote, double quote, parentheses, and braces should also
> delineate words. $(, ${, $((, ((, )), [[, ]], should be words. I
> would
> exclude single brackets because they could only occur in globs, IIRC,
> and they need not be broken into words at brackets. $var should be a
> single word, IMO.
> 
> That said, this can be presented as a patch on top of this one.

I can't tell where this word definition is used, and I can't seem to find any tests for the word regexes for the other languages. Is it used for word diffs somehow? I'll leave it for now, but if you have some pointers I could look into that later.

Thank you very much for the comments!