git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] format-patch: make output filename configurable

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 10, 2020, 02:37 UTC
Message-ID
<xmqqr1p27x8d.fsf@gitster.c.googlers.com>
In-Reply-To
<9d4b387655024b24a20ce2384740b03a@huawei.com>
hukeping <hukeping@huawei.com> writes:
Show 5 quoted lines
> It would be very hard to remove a config knob rather than add a
> new one and we already have too many.
>
> Does it worth to add a new configuration variable for this or just
> a hard-coded value is enough?

I personally would say "yes, the current code that limits to 64 is enough", but you, as the person who said that you do not like the current hard-coded value, are not in the position to ask that question, I would have to say---if it were enough for you, you wouldn't have complained about 64 in the first place ;-)

Previous: hukepingNext: hukeping
Message 13 of 15 in “Lengthening FORMAT_PATCH_NAME_MAX to 80”
  1. Lengthening FORMAT_PATCH_NAME_MAX to 80Hu Keping, Nov 5, 2020
  2. Jeff KingNov 5, 2020
  3. Junio C HamanoNov 5, 2020
  4. hukepingNov 6, 2020
  5. Junio C HamanoNov 6, 2020
  6. Junio C HamanoNov 6, 2020
  7. format-patch: make output filename configurableJunio C Hamano, Nov 6, 2020
  8. Eric SunshineNov 6, 2020
  9. format-patch: make output filename configurableJunio C Hamano, Nov 9, 2020
  10. Jeff KingNov 10, 2020
  11. Junio C HamanoNov 10, 2020
  12. hukepingNov 10, 2020
  13. Junio C HamanoNov 10, 2020
  14. hukepingNov 10, 2020
  15. Junio C HamanoNov 10, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.