RE: [PATCH v2] format-patch: make output filename configurable

From: hukeping <hukeping@huawei.com>
Date: Nov 10, 2020, 04:44 UTC
Message-ID: <8b97c61e983c432aab1063912d6266b9@huawei.com>
In-Reply-To: <xmqqr1p27x8d.fsf@gitster.c.googlers.com>

Show 10 quoted lines

>> It would be very hard to remove a config knob rather than add a new
>> one and we already have too many.
>>
>> Does it worth to add a new configuration variable for this or just a
>> hard-coded value is enough?
>
>I personally would say "yes, the current code that limits to 64 is enough", but you,
>as the person who said that you do not like the current hard-coded value, are not
>in the position to ask that question, I would have to say---if it were enough for
>you, you wouldn't have complained about 64 in the first place ;-)

The original motivation is to lengthening the limit because of file name truncated problem, so update the value to a larger one seems like the simplest way for me.

The v2 patch can fundamentally solve this problem, just a little worry about the more and more git-config knobs.