Re: [PATCH v2 01/26] completion: bash: fix prefix detection in branch.*

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 25, 2020, 20:37 UTC
Message-ID: <xmqqr1ohdvfi.fsf@gitster.c.googlers.com>
In-Reply-To: <20201125084814.GE8396@szeder.dev>

SZEDER Gábor <szeder.dev@gmail.com> writes:

Show 28 quoted lines

> On Tue, Nov 10, 2020 at 03:21:11PM -0600, Felipe Contreras wrote:
>> Otherwise we are completely ignoring the --cur argument.
>> 
>> The issue can be tested with:
>> 
>>   git clone --config=branch.<tab>
>> 
>> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
>> ---
>>  contrib/completion/git-completion.bash | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
>> index 7c81e4ba49..b866b68b3c 100644
>> --- a/contrib/completion/git-completion.bash
>> +++ b/contrib/completion/git-completion.bash
>> @@ -2615,8 +2615,8 @@ __git_complete_config_variable_name ()
>>  		return
>>  		;;
>>  	branch.*)
>> -		local pfx="${cur%.*}."
>> -		cur_="${cur#*.}"
>> +		local pfx="${cur_%.*}."
>> +		cur_="${cur_#*.}"
>
> Indeed, somehow this case was only half-converted in 5af9d5f6c8
> (completion: complete config variables and values for 'git clone
> --config=', 2019-08-13), thanks.

Very much appreciated a review on this step, and it would be even more appreciated if the whole series gets some review, as we do not want to merge a series that has not been looked at.

Thanks.