[PATCH v2 07/26] completion: bash: remove non-append functionality
- From
Felipe Contreras <felipe.contreras@gmail.com>
- Date
- Nov 10, 2020, 21:21 UTC
- Message-ID
- <20201110212136.870769-8-felipe.contreras@gmail.com>
- In-Reply-To
- <20201110212136.870769-1-felipe.contreras@gmail.com>
There's no point in setting COMPREPLY only to override it later, and in fact; we don't do that.
Therefore there's no functional difference between __gitcomp_direct() and __gitcomp_direct_append(), since __gitcomp_direct() *always* operates on empty COMPREPLY.
The same goes for __gitcomp_nl().
This patch makes the functionality of append and non-append functions the same.
There should be no functional changes.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> --- contrib/completion/git-completion.bash | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index 12275a3558..6a1106f17d 100644 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -298,7 +298,7 @@ __gitcomp_direct () { local IFS=$'\n' - COMPREPLY=($1) + COMPREPLY+=($1) } # Similar to __gitcomp_direct, but appends to COMPREPLY instead. @@ -450,7 +450,6 @@ __gitcomp_nl_append () # appended. __gitcomp_nl () { - COMPREPLY=() __gitcomp_nl_append "$@" }
-- 2.29.2