Re: [PATCH v2 0/2] make macOS `git maintenance` test work on Windows
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 30, 2020, 23:32 UTC
- Message-ID
- <xmqqr1oato8m.fsf@gitster.c.googlers.com>
- In-Reply-To
- <87blffjkne.fsf@evledraar.gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
Show 10 quoted lines
> Also as another aside (but your patch is fine as it is), my suggestion > used Perl+Perl RX but you switched it to sed+BRE. Do we want to avoid > "sed -E"? I wondered that for something else the other day, we have > this: > > t/check-non-portable-shell.pl: /\bsed\s+-[^efn]\s+/ and err 'sed option not portable (use only -n, -e, -f)'; > > So maybe it means "nothing but -nef, or maybe "don't use -efn". The ERE > (-E and -r) options aren't mentioned, and a naïve log search of of "sed > -E" and "sed -r" in t/ returns nothing.
Correct. We currently do not use "sed -E", and the script says "Let's not use it; it's not even in POSIX" for things other than 'n', 'e', and 'f'.
https://pubs.opengroup.org/onlinepubs/9699919799/utilities/sed.html
Thanks.