git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/2] t7900: make macOS-specific test work on Windows

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Dec 1, 2020, 03:03 UTC
Message-ID
<CAPig+cSK4y2P2PUVnXyaB5T0y-RBJOsb-npwM_8Wnm7oqRQLGQ@mail.gmail.com>
In-Reply-To
<e4647058-3bb6-7aa4-c245-95e3f4b3bc66@gmail.com>
On Mon, Nov 30, 2020 at 8:12 AM Derrick Stolee <stolee@gmail.com> wrote:
Show 7 quoted lines
> On 11/29/2020 11:42 PM, Eric Sunshine wrote:
> > +     # ensure $HOME can be compared against hook arguments on all platforms
> > +     pfx=$(cd "$HOME" && pwd) &&
> > +             PLIST="$pfx/Library/LaunchAgents/org.git-scm.git.$frequency.plist" &&
>
> This pair of changes make sense to get around the $HOME issue
> that caused me to surrender the effort.

In case it's not clear to other readers not familiar with Git on Windows (or who have not read t/README), the magic here is that `pwd` is overridden in t/test-lib.sh for MINGW to always return a Windows-style path.

Previous: Derrick StoleeNext: Ævar Arnfjörð Bjarmason
Message 5 of 9 in “make macOS `git maintenance` test work on Windows”
  1. 0/2 make macOS `git maintenance` test work on WindowsEric Sunshine, Nov 30, 2020
  2. 1/2 t7900: fix test failures when invoked individually via --runEric Sunshine, Nov 30, 2020
  3. 2/2 t7900: make macOS-specific test work on WindowsEric Sunshine, Nov 30, 2020
  4. Derrick StoleeNov 30, 2020
  5. Eric SunshineDec 1, 2020
  6. Ævar Arnfjörð BjarmasonNov 30, 2020
  7. Junio C HamanoNov 30, 2020
  8. Eric SunshineDec 1, 2020
  9. Johannes SchindelinDec 1, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.