Re: [PATCH v1 1/1] pathspec: warn for a no-glob entry that contains `**`

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 25, 2021, 20:09 UTC
Message-ID: <xmqqr1k3uhae.fsf@gitster.g>
In-Reply-To: <20210325160921.12187-1-133706+stdedos@users.noreply.github.com>

Stavros Ntentos <stdedos@gmail.com> writes:

> Ofc, if someone really wanted to solve this, someone
> could rework the `void vreportf` split and auto-pad
> prefix at newline, but sounds like a project on its own ...

But when it happens, this extra "\t" would get in the way and needs to be adjusted ;-)

It has been on the radar for quite some time to apply the same principle for die(), error(), and warning() as how advise() shows its "hint:" prefix.

The format strings given to these functions are end-user-facing and subject to localization, so there is no huge compatibility issues we need to be worried about.

The test suite have fixed expectations and such a change must be accompanied by adjustment to the affected tests, though.