Re: mr/bisect-in-c-4, was Re: What's cooking in git.git (Sep 2021, #02; Wed, 8)

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 10, 2021, 05:07 UTC
Message-ID: <xmqqr1dxuigf.fsf@gitster.g>
In-Reply-To: <nycvar.QRO.7.76.6.2109091308200.59@tvgsbejvaqbjf.bet>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 13 quoted lines

> On Wed, 8 Sep 2021, Junio C Hamano wrote:
>
>> * mr/bisect-in-c-4 (2021-09-02) 6 commits
>>  - bisect--helper: retire `--bisect-next-check` subcommand
>>  - bisect--helper: reimplement `bisect_run` shell
>>  - bisect--helper: reimplement `bisect_visualize()`shell function in C
>>  - run-command: make `exists_in_PATH()` non-static
>>  - t6030-bisect-porcelain: add test for bisect visualize
>>  - t6030-bisect-porcelain: add tests to control bisect run exit cases
>>
>>  Rewrite of "git bisect" in C continues.
>
> From my point of view, this is ready for `next`.

You agreed that redirection with dup2()'s in [5/6] was good enough for now [*1*], but in that case, we need to add a few fflush(stdout) around the dup2() dance [*2*].

So this is not quite ready for 'next' yet, although it is almost there, I'd think.

[References]

*1* https://lore.kernel.org/git/nycvar.QRO.7.76.6.2109090922310.55@tvgsbejvaqbjf.bet/

*2* https://lore.kernel.org/git/xmqqtuj2h7cp.fsf@gitster.g/