Re: What's cooking in git.git (Sep 2021, #02; Wed, 8)

From: Elijah Newren <newren@gmail.com>
Date: Sep 9, 2021, 14:23 UTC
Message-ID: <CABPp-BH1Zdh7esBKeUu9hr4tM9kO=dgpyDwCMnsJ=XGxpZ7RvQ@mail.gmail.com>
In-Reply-To: <d6721839-114a-3309-25aa-1926fa198bf7@gmail.com>

On Wed, Sep 8, 2021 at 2:57 PM Derrick Stolee <stolee@gmail.com> wrote:

Show 23 quoted lines

>
> On 9/8/2021 11:38 AM, Junio C Hamano wrote:> * ds/sparse-index-ignored-files (2021-09-07) 10 commits
> >  - sparse-checkout: clear tracked sparse dirs
> >  - sparse-index: add SPARSE_INDEX_MEMORY_ONLY flag
> >  - attr: be careful about sparse directories
> >  - sparse-checkout: create helper methods
> >  - sparse-index: use WRITE_TREE_MISSING_OK
> >  - sparse-index: silently return when cache tree fails
> >  - unpack-trees: fix nested sparse-dir search
> >  - sparse-index: silently return when not using cone-mode patterns
> >  - t7519: rewrite sparse index test
> >  - Merge branch 'ds/add-with-sparse-index' into ds/sparse-index-ignored-files
> >  (this branch is used by sg/test-split-index-fix.)
> >
> >  In cone mode, the sparse-index codepath learned to remove ignored
> >  files (like build artifacts) outside the sparse cone, allowing the
> >  entire directory outside the sparse cone to be removed, which is
> >  especially useful when the sparse patterns change.
> >
> >  Will merge to 'next'?
>
> I think this one is ready to go. Elijah chimed in on the latest
> version, too.

Yep, looks good to me.

Show 6 quoted lines

> This also means that perhaps we could start tracking the sparse
> index integrations with merge, rebase, cherry-pick, and revert [1]?
> This series has also had quite a bit of review, but the latest
> version has not had an ack.
>
> [1] https://lore.kernel.org/git/pull.1019.v3.git.1631100241.gitgitgadget@gmail.com

v2 was already nearly ready to go, with just some very minor comments and questions. Your email responses to individual patches explained most of the remaining bits, leaving just the typo, which you corrected in v3. So, I went ahead and put my Reviewed-by on it.

If this series had been picked up by Junio and listed in the "What's cooking" email, I'd suggest it was also ready for next.

Show 5 quoted lines

> I also plan to send a new version of the --sparse RFC [2], which
> is based on [1]. I don't want to get too far ahead of what the
> community has capacity to review.
>
> [2] https://lore.kernel.org/git/pull.1018.git.1629842085.gitgitgadget@gmail.com/

Sorry for not responding. I found a simple typo but wanted to have something more to say than just that. I was happy with what looked like the high level direction, and then noticed that Matheus was giving you lots of good comments and he understood some of the details better than me. I'll try to find some time to review when you send the re-roll.