Re: [PATCH 2/2] branch.c: adjust error messages to coding guidelines

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 13, 2023, 18:29 UTC
Message-ID: <xmqqr0lyz88v.fsf@gitster.g>
In-Reply-To: <CAJHH8bE15VotFy7QQ-Npmfk9ePvf=-h5SP+Q8phrDBRj8Ti=hQ@mail.gmail.com>

Isoken Ibizugbe <isokenjune@gmail.com> writes:

> I am sorry if I made any mistakes, It's my first time using
> gitgitgadget. This commit was already sent before through git-send
> email. The patch was intended to submit the revisions.

I cannot help with GGG, but it looked strange for this change to be in two patches, especially since what the rule of deciding which message is to be touched in which one of the two patches were not explained anywhere in the series.

I suspect what you want to do is to squash these two commits down into a single commit, review the resulting code change and also the commit log message to see if the latter still matches what the combined patch does, update them as needed, run the test suite again.

And then format-patch without the cover letter to send the resulting patch out. Or force push to tell GGG to resend a new iteration without any cover letter.

Thanks.