Re: [PATCH 0/2] [Outreachy][PATCH v2] branch.c: adjust error messages to coding guidelines

From: Rubén Justo <rjusto@gmail.com>
Date: Oct 13, 2023, 18:30 UTC
Message-ID: <aed9523e-0ce9-49f6-bdda-90fd1e275691@gmail.com>
In-Reply-To: <pull.1590.git.git.1697211227.gitgitgadget@gmail.com>

On 13-oct-2023 15:33:45, Isoken June Ibizugbe via GitGitGadget wrote:

Show 9 quoted lines

> As per the CodingGuidelines document, it is recommended that a single-line
> message provided to error messages such as die(), error() and warning(),
> should start with a lowercase letter and should not end with a period.
> 
> Signed-off-by: Isoken June Ibizugbe isokenjune@gmail.com
> 
> Isoken June Ibizugbe (2):
>   branch.c: ammend error messages for die()
>   branch.c: adjust error messages to coding guidelines

I don't understand why two commits. Maybe it was unintentional and you want to merge all changes into one commit, using git rebase.

> 
>  builtin/branch.c | 66 ++++++++++++++++++++++++------------------------
>  1 file changed, 33 insertions(+), 33 deletions(-)

You still need to adjust the tests.  Take a look at:

https://github.com/git/git/actions/runs/6509642887/job/17681596358