Re: [PATCH 1/5] t7300: work around platform-specific behaviour with long paths on MinGW

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 9, 2024, 18:31 UTC
Message-ID: <xmqqr08pruv6.fsf@gitster.g>
In-Reply-To: <bdaf16a06168b7320e8dd1115258f00745a104c7.1728480039.git.ps@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 8 quoted lines

> diff --git a/t/t7300-clean.sh b/t/t7300-clean.sh
> index 0aae0dee67..12ab25296b 100755
> --- a/t/t7300-clean.sh
> +++ b/t/t7300-clean.sh
> @@ -747,7 +747,7 @@ test_expect_success MINGW 'handle clean & core.longpaths = false nicely' '
>  	test_must_fail git clean -xdf 2>.git/err &&
>  	# grepping for a strerror string is unportable but it is OK here with
>  	# MINGW prereq

I find it amusing that this talks about limiting the test to MINGW yet we need to accept two variants ;-)

> -	test_grep "too long" .git/err
> +	test_grep -e "too long" -e "No such file or directory" .git/err
>  '

The solution looks obviously good enough.

Thanks.