Re: [PATCH 1/5] t7300: work around platform-specific behaviour with long paths on MinGW

From: Patrick Steinhardt <ps@pks.im>
Date: Oct 10, 2024, 05:56 UTC
Message-ID: <ZwdsgHdNp108lISP@pks.im>
In-Reply-To: <xmqqr08pruv6.fsf@gitster.g>

On Wed, Oct 09, 2024 at 11:31:25AM -0700, Junio C Hamano wrote:

Show 13 quoted lines

> Patrick Steinhardt <ps@pks.im> writes:
> 
> > diff --git a/t/t7300-clean.sh b/t/t7300-clean.sh
> > index 0aae0dee67..12ab25296b 100755
> > --- a/t/t7300-clean.sh
> > +++ b/t/t7300-clean.sh
> > @@ -747,7 +747,7 @@ test_expect_success MINGW 'handle clean & core.longpaths = false nicely' '
> >  	test_must_fail git clean -xdf 2>.git/err &&
> >  	# grepping for a strerror string is unportable but it is OK here with
> >  	# MINGW prereq
> 
> I find it amusing that this talks about limiting the test to MINGW
> yet we need to accept two variants ;-)

Agreed, I was quite confused by this. I hope that Johannes may shed a bit more light on this, as I couldn't make much sense of it. Was this a change on our side? Did MinGW change? Is it something else entirely? No idea.

Patrick