Re: meson-test syntax error

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 2, 2025, 15:39 UTC
Message-ID: <xmqqr05lusvp.fsf@gitster.g>
In-Reply-To: <Z3avRmaMr70FOs8A@google.com>

Jonathan Nieder <jrnieder@gmail.com> writes:

Show 21 quoted lines

> Junio C Hamano wrote:
>> Jonathan Nieder <jrnieder@gmail.com> writes:
>>> Andy Koppe wrote:
>
>>>>   make[1]: Entering directory '/src/git/t'
>>>>   rm -f -r 'test-results'
>>>>   /bin/sh: 10: Syntax error: "(" unexpected
>>>>   make[1]: *** [Makefile:119: check-meson] Error 2
>>>>
>>>> Due to this line:
>>>>
>>>>   diff -u <(echo "$$meson_tests") <(echo "$$actual_tests");
> [...]
>>> I ran into the same today.  Let's discuss in the review thread
>>> (https://lore.kernel.org/git/20241213-pks-meson-ci-v2-5-634affccc694@pks.im/).
>>
>> Probably this one?
>>
>> <20241227-b4-pks-meson-docs-v2-11-f61e63edbfa1@pks.im>
>
> Ah, yes, that's the one I mean.  Sorry for the noise.

Sorry for being extra sloppy on this one. A patch like that with blatant bash-ism shouldn't have slipped the review process.

One thing I had trouble with is that, with /bin/sh linked to /bin/bash, none of these

    $ SHELL=/bin/dash make test
    $ cd t && SHELL=/bin/dash make test
    $ cd t && SHELL=/bin/dash make check-meson

seem to fail for me.