git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: meson-test syntax error

From
Patrick Steinhardt <ps@pks.im>
Date
Jan 3, 2025, 06:40 UTC
Message-ID
<Z3eGS68PkwDtBl1V@pks.im>
In-Reply-To
<xmqqr05lusvp.fsf@gitster.g>
On Thu, Jan 02, 2025 at 07:39:54AM -0800, Junio C Hamano wrote:
Show 35 quoted lines
> Jonathan Nieder <jrnieder@gmail.com> writes:
> 
> > Junio C Hamano wrote:
> >> Jonathan Nieder <jrnieder@gmail.com> writes:
> >>> Andy Koppe wrote:
> >
> >>>>   make[1]: Entering directory '/src/git/t'
> >>>>   rm -f -r 'test-results'
> >>>>   /bin/sh: 10: Syntax error: "(" unexpected
> >>>>   make[1]: *** [Makefile:119: check-meson] Error 2
> >>>>
> >>>> Due to this line:
> >>>>
> >>>>   diff -u <(echo "$$meson_tests") <(echo "$$actual_tests");
> > [...]
> >>> I ran into the same today.  Let's discuss in the review thread
> >>> (https://lore.kernel.org/git/20241213-pks-meson-ci-v2-5-634affccc694@pks.im/).
> >>
> >> Probably this one?
> >>
> >> <20241227-b4-pks-meson-docs-v2-11-f61e63edbfa1@pks.im>
> >
> > Ah, yes, that's the one I mean.  Sorry for the noise.
> 
> Sorry for being extra sloppy on this one.  A patch like that with
> blatant bash-ism shouldn't have slipped the review process.
> 
> One thing I had trouble with is that, with /bin/sh linked to
> /bin/bash, none of these
> 
>     $ SHELL=/bin/dash make test
>     $ cd t && SHELL=/bin/dash make test
>     $ cd t && SHELL=/bin/dash make check-meson
> 
> seem to fail for me.
Sorry, as well. Thanks for the report and investigations!
Patrick
Previous: Junio C Hamano
Message 10 of 10 in “meson-test syntax error”
  1. Andy KoppeJan 2, 2025
  2. Jonathan NiederJan 2, 2025
  3. Junio C HamanoJan 2, 2025
  4. Jonathan NiederJan 2, 2025
  5. Junio C HamanoJan 2, 2025
  6. Junio C HamanoJan 2, 2025
  7. Junio C HamanoJan 2, 2025
  8. Andreas SchwabJan 2, 2025
  9. Junio C HamanoJan 2, 2025
  10. Patrick SteinhardtJan 3, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.