Re: [PATCH v2] trace2: prevent segfault on config collection where no value specified

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 23, 2025, 18:02 UTC
Message-ID: <xmqqr04ts916.fsf@gitster.g>
In-Reply-To: <CALnO6CDH1aQrq0tcvr4rEGukksYv5bJ9W4icqBUC2Z3AyixRUw@mail.gmail.com>

"D. Ben Knoble" <ben.knoble@gmail.com> writes:

Show 6 quoted lines

> I was curious what changed, so I found 792a3850fa (trace2: prevent
> segfault on config collection with valueless true, 2025-01-10) and I
> noticed this:
>
> -       redacted = redact_arg(value);
> +       redacted = value ? redact_arg(value): NULL;

Oh, I do not think I tweaked any of the code, other than fixing the new test that was not properly formatted. Mostly I touched up the log message.

Will touch it up.  Thanks for a careful reading.