Re: [PATCH v2] trace2: prevent segfault on config collection where no value specified

From: D. Ben Knoble <ben.knoble@gmail.com>
Date: Jan 23, 2025, 21:15 UTC
Message-ID: <CALnO6CAcv+544jRdp9VO1d38dvHX6MNfu4VLKenjKZCsCaf14Q@mail.gmail.com>
In-Reply-To: <xmqqr04ts916.fsf@gitster.g>

On Thu, Jan 23, 2025 at 1:02 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 13 quoted lines

>
> "D. Ben Knoble" <ben.knoble@gmail.com> writes:
>
> > I was curious what changed, so I found 792a3850fa (trace2: prevent
> > segfault on config collection with valueless true, 2025-01-10) and I
> > noticed this:
> >
> > -       redacted = redact_arg(value);
> > +       redacted = value ? redact_arg(value): NULL;
>
> Oh, I do not think I tweaked any of the code, other than fixing the
> new test that was not properly formatted.  Mostly I touched up the
> log message.

I could have been clearer—I think this was in the original. I just happened to notice it because I was curious about what touch-ups you performed :)

-- 
D. Ben Knoble