Re: [PATCH v2 4/4] bisect: simplify string_list memory handling

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 30, 2026, 16:56 UTC
Message-ID: <xmqqqzr76nuj.fsf@gitster.g>
In-Reply-To: <20260130-b4-pks-fix-for-each-ref-in-misuse-v2-4-0449b198a681@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

> It was written this way originally because one of the callsites
> generated the item using xstrfmt(). But that spot switched to a plain
> xstrdup() in the preceding commit. That means we can now just let the
> string_list code handle allocation itself.

Thanks for an extra attention to the detail of the way to refer the previous change ;-).

I think [2/4] is a good direction myself, but I'd prefer to hear Taylor's opinion as well.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.