Re: [PATCH 0/3] Fix misuse of `refs_for_each_ref_in()`

From: Karthik Nayak <karthik.188@gmail.com>
Date: Jan 28, 2026, 11:05 UTC
Message-ID: <CAOLa=ZTX1uGBgsxXFPTBujLmMgKw-X1HB1reZ2jar7yeSnzH0g@mail.gmail.com>
In-Reply-To: <20260128-b4-pks-fix-for-each-ref-in-misuse-v1-0-deccae3ea725@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 18 quoted lines

> Hi,
>
> this small patch series fixes a bug I have discovered where configuring
> "pack.preferBitmapTips" to an exact branch will cause Git to `BUG()`.
>
> The root cause of this bug is misuse of `refs_for_each_ref_in()`: this
> function accepts a prefix to yield refs for, and then strips the prefix
> for each ref. Consequently, if passed an exact refname, then stripping
> the prefix would make us end up with an empty refname, and that is not
> supposed to happen.
>
> There was one other caller that got it wrong, too, and which is also
> fixed in this patch series.
>
> Thanks!
>
> Patrick
>

The patches look good, thanks for the fix!