Re: [PATCH v7 5/5] rebase: support --trailer

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 3, 2026, 21:18 UTC
Message-ID: <xmqqqzq0boi8.fsf@gitster.g>
In-Reply-To: <22e1de8e-935d-4efa-9fa8-ef8d9b4ffc6a@app.fastmail.com>

"Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com> writes:

Show 6 quoted lines

>> I wonder if it would be better to add the trailers before the signoff so
>> that "git rebase --signoff --trailer='Reviewed-by: ...'" adds the
>> "Reviewed-by:" trailer before the "Signed-off-by:" trailer.
>
> Why is that? Is that because that is the practice in this project (and
> maybe others)?

I do not think it is a good idea for the above sample command, where we can argue that the intent of the user is to have sign-off and then reviewed-by, expressed in the order of options given.

If we want to control where the new trailers are added, perhaps we would need to match the --where option interpret-trailers has and let the configuration honored by that command take care of the ordering.