git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v7 0/5] rebase: support --trailer

From
PWPhillip Wood <phillip.wood123@gmail.com>
Date
Feb 26, 2026, 18:15 UTC
Message-ID
<83cac4b2-c59d-4ab2-9dfc-2f615ed3959d@gmail.com>
In-Reply-To
<xmqqecm74fcd.fsf@gitster.g>
On 26/02/2026 16:52, Junio C Hamano wrote:
Show 29 quoted lines
> Li Chen <me@linux.beauty> writes:
> 
>     > Apologies for the long delay in sending v7.
>>
>> v7 is based on origin/master at v2.53.0-154-g7c02d39fc2.
>>
>> This series routes trailer insertion through an in-process path, removing the
>> fork/exec to builtin/interpret-trailers.
>>
>> The first four commits refactor trailer rewriting in builtin/interpret-trailers
>> and trailer.c so callers can reuse a single in-process helper (used by git
>> interpret-trailers, git commit and git tag). The final commit adds git rebase
>> --trailer, currently supported with the merge backend only (rejecting apply-only
>> scenarios and validating input early).
>>
>> v7:
>> Rebased onto origin/master at v2.53.0-154-g7c02d39fc2.
>> Split out a new patch to parse --trailer with OPT_STRVEC in git commit and git
>> tag.
>> Use strbuf_write() in interpret-trailers when emitting buffered output.
>> Restore --in-place rewriting semantics via tempfile+rename.
>> Drop wrapper.c/h and validate trailer args via validate_trailer_args().
>> Drop redundant rebase basic-state save/restore for --trailer arguments.
>> ...
>> Comments very very welcome!
> 
> Yes indeed.  The discussion thread for v6 saw quite a bit of
> activity, but this one is quiet.  Is everybody happy with this
> iteration?

I've not had chance to read this version yet, I'm planning to do so next week.

Thanks
Phillip
Previous: Junio C HamanoNext: Kristoffer Haugsbakk
Message 18 of 32 in “rebase: support --trailer”
  1. 0/5 rebase: support --trailerLi Chen, Feb 24, 2026
  2. 1/5 interpret-trailers: factor trailer rewritingLi Chen, Feb 24, 2026
  3. Phillip WoodMar 2, 2026
  4. Li ChenMar 2, 2026
  5. 2/5 trailer: move process_trailers to trailer.hLi Chen, Feb 24, 2026
  6. phillip.wood123@gmail.comMar 2, 2026
  7. 3/5 trailer: append trailers without fork/execLi Chen, Feb 24, 2026
  8. Phillip WoodMar 2, 2026
  9. 4/5 commit, tag: parse --trailer with OPT_STRVECLi Chen, Feb 24, 2026
  10. Phillip WoodMar 2, 2026
  11. 5/5 rebase: support --trailerLi Chen, Feb 24, 2026
  12. Phillip WoodMar 3, 2026
  13. Kristoffer HaugsbakkMar 3, 2026
  14. Junio C HamanoMar 3, 2026
  15. Phillip WoodMar 4, 2026
  16. Junio C HamanoMar 4, 2026
  17. Junio C HamanoFeb 26, 2026
  18. Phillip WoodFeb 26, 2026
  19. Kristoffer HaugsbakkFeb 26, 2026
  20. Phillip WoodMar 4, 2026
  21. Li ChenMar 5, 2026
  22. Phillip WoodMar 6, 2026
  23. 0/6 rebase: support --trailerPhillip Wood, Mar 6, 2026
  24. 1/6 interpret-trailers: factor trailer rewritingPhillip Wood, Mar 6, 2026
  25. Junio C HamanoMar 6, 2026
  26. Phillip WoodMar 9, 2026
  27. 2/6 interpret-trailers: refactor create_in_place_tempfile()Phillip Wood, Mar 6, 2026
  28. Junio C HamanoMar 6, 2026
  29. 3/6 trailer: libify a couple of functionsPhillip Wood, Mar 6, 2026
  30. 4/6 trailer: append trailers without fork/execPhillip Wood, Mar 6, 2026
  31. 5/6 commit, tag: parse --trailer with OPT_STRVECPhillip Wood, Mar 6, 2026
  32. 6/6 rebase: support --trailerPhillip Wood, Mar 6, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.