Re: [PATCH v7 0/5] rebase: support --trailer
- From
- Phillip Wood <phillip.wood123@gmail.com>
- Date
- Feb 26, 2026, 18:15 UTC
- Message-ID
- <83cac4b2-c59d-4ab2-9dfc-2f615ed3959d@gmail.com>
- In-Reply-To
- <xmqqecm74fcd.fsf@gitster.g>
On 26/02/2026 16:52, Junio C Hamano wrote:
Show 29 quoted lines
> Li Chen <me@linux.beauty> writes: > > > Apologies for the long delay in sending v7. >> >> v7 is based on origin/master at v2.53.0-154-g7c02d39fc2. >> >> This series routes trailer insertion through an in-process path, removing the >> fork/exec to builtin/interpret-trailers. >> >> The first four commits refactor trailer rewriting in builtin/interpret-trailers >> and trailer.c so callers can reuse a single in-process helper (used by git >> interpret-trailers, git commit and git tag). The final commit adds git rebase >> --trailer, currently supported with the merge backend only (rejecting apply-only >> scenarios and validating input early). >> >> v7: >> Rebased onto origin/master at v2.53.0-154-g7c02d39fc2. >> Split out a new patch to parse --trailer with OPT_STRVEC in git commit and git >> tag. >> Use strbuf_write() in interpret-trailers when emitting buffered output. >> Restore --in-place rewriting semantics via tempfile+rename. >> Drop wrapper.c/h and validate trailer args via validate_trailer_args(). >> Drop redundant rebase basic-state save/restore for --trailer arguments. >> ... >> Comments very very welcome! > > Yes indeed. The discussion thread for v6 saw quite a bit of > activity, but this one is quiet. Is everybody happy with this > iteration?
I've not had chance to read this version yet, I'm planning to do so next week.
Thanks
Phillip