Re: [PATCH v2 11/11] ci: run expensive tests on push builds to integration branches
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 8, 2026, 02:50 UTC
- Message-ID
- <xmqqqznmfwd1.fsf@gitster.g>
- In-Reply-To
- <xmqq5x52nhg6.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 25 quoted lines
> Derrick Stolee <stolee@gmail.com> writes: > >> On 5/4/2026 1:08 PM, Johannes Schindelin via GitGitGadget wrote: >>> From: Johannes Schindelin <johannes.schindelin@gmx.de> >>> >>> Derrick Stolee suggested [1] that expensive tests should be run at a >>> regular cadence rather than on every PR iteration. Gate GIT_TEST_LONG >>> on push builds to the integration branches (next, master, main, maint) >>> so that the EXPENSIVE prereq is satisfied there but not during PR >>> validation, where the extra minutes of wall-clock time do not justify >>> themselves. >> I like that this will be run as part of regular updates to the >> important branches. The important bit after that is whether or >> not a human pays attention to the signal of these builds. >> >> Junio: Do you pay attention to CI breaks when you push to >> 'master'? > > Well, it is way too late to notice breakage when the faulty update > hits 'master'. CI failures should be noticed before breakage hits > 'next'. > > I often notice and complain when I see failures on 'seen', and > sometimes I help original submitter by bisecting, but I do not > necessarily have enough time and bandwidth to help everybody.
To more directly answer your question, yes I do pay attention, but not only when I push to 'master', but when I push to any of the integration branches. I pay most attention to breakage in 'seen', so that I can notify authors of new topics early. Sometimes you may see many pushes only to 'seen' at github.com/git/git while 'seen' on the other hosting sites are not updated with these commits, and if you notice them, you caught me bisecting the breakage on it. This is so that I can eject offending topics and notify the author.
But this does not scale, and I shouldn't have to do it myself.
Making sure the topics come in a shape that they pass the tests before they hit my tree is one way to reduce the need for the maintainer bottleneck.
Show 10 quoted lines
> It would be best to find problems early, and make it easier for > individual contributors to help each other by having a concrete CI > failure reports in their forks that they can point at when they ask > for help. And CI run when I push 'seen' or 'master' out would not > help as much as CI run when they publish their forked branches would. > > By the way, please expect slow responses as I am (officially) still > mostly offline for the rest of the week. > > Thanks.