git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] t5551: "GIT_TEST_LONG=Yes make test" is broken

From
Junio C Hamano <gitster@pobox.com>
Date
May 8, 2026, 05:31 UTC
Message-ID
<xmqqqznmeaco.fsf@gitster.g>

The "test_expect_success 'tag following always works over v0 http'" test in t5551 fails when it tries to run "git init tags", but this happens only when EXPENSIVE test is allowed to run.

This is because the step tries to create a repository with "git init tags" but the EXPENSIVE test that runs way before it creates and leaves around a temporary file "tags". Have the EXPENSIVE test clean it up after itself.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 * As we should give individual contributors a stable base, I have
   identified tests that fail with EXPENSIVE enabled in "master".
   With this fixed, we should add GIT_TEST_LONG=YesPlease to the CI
   jobs run upon PRs are created by contributors.
 t/t5551-http-fetch-smart.sh | 1 +
 1 file changed, 1 insertion(+)
diff --git c/t/t5551-http-fetch-smart.sh w/t/t5551-http-fetch-smart.sh
index a26b6c2844..e236e526f0 100755
--- c/t/t5551-http-fetch-smart.sh
+++ w/t/t5551-http-fetch-smart.sh
@@ -481,6 +481,7 @@ test_expect_success 'test allowanysha1inwant with unreachable' '
 '
 
 test_expect_success EXPENSIVE 'http can handle enormous ref negotiation' '
+	test_when_finished "rm -f tags" &&
 	(
 		cd "$HTTPD_DOCUMENT_ROOT_PATH/repo.git" &&
 		create_tags 2001 50000
Next: Jeff King
Message 1 of 2 in “t5551: "GIT_TEST_LONG=Yes make test" is broken”
  1. t5551: "GIT_TEST_LONG=Yes make test" is brokenJunio C Hamano, May 8, 2026
  2. Jeff KingMay 8, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.