git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t5551: "GIT_TEST_LONG=Yes make test" is broken

From
Jeff King <peff@peff.net>
Date
May 8, 2026, 14:03 UTC
Message-ID
<20260508140355.GA709299@coredump.intra.peff.net>
In-Reply-To
<xmqqqznmeaco.fsf@gitster.g>
On Fri, May 08, 2026 at 02:31:03PM +0900, Junio C Hamano wrote:
Show 8 quoted lines
> The "test_expect_success 'tag following always works over v0 http'"
> test in t5551 fails when it tries to run "git init tags", but this
> happens only when EXPENSIVE test is allowed to run.  
> 
> This is because the step tries to create a repository with "git init
> tags" but the EXPENSIVE test that runs way before it creates and
> leaves around a temporary file "tags".  Have the EXPENSIVE test
> clean it up after itself.

I wondered how and when this broke, but it looks like it has been since 2024 when the later v0 test was added. And it looks like I am the culprit for both the EXPENSIVE test adding the "tags" file and the v0 test assuming the path is available. :)

Anyway, this seems like the obviously correct solution.
-Peff
Previous: Junio C Hamano
Message 2 of 2 in “t5551: "GIT_TEST_LONG=Yes make test" is broken”
  1. t5551: "GIT_TEST_LONG=Yes make test" is brokenJunio C Hamano, May 8, 2026
  2. Jeff KingMay 8, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.